Skip to content

Switch the underlying xml implementation to the one from maven #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Switch the underlying xml implementation to the one from maven #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa24518
Fix Xpp3Dom#mergeIntoXpp3Dom to behave similar to Xpp3DomUtils#mergeI…
gnodet Feb 9, 2023
5fe1e75
Switch the underlying xml implementation to the one from maven
gnodet Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@ limitations under the License.
</properties>

<dependencies>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-xml</artifactId>
<version>4.0.0-alpha-4</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it weird to depend on a version 4.0.0-alpha-4
I already fear the dependabot upgrades in the future when new Maven releases happen

</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-xml-impl</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one https://github.com/apache/maven/blob/maven-4.0.0-alpha-4/maven-xml-impl/pom.xml depends on sisu plexus
and sisu plexus depends on many many things, including plexus-utils (not provided, as at least maven-xml-impl did as a workaround for these circular dependencies): https://github.com/eclipse/sisu.plexus/blob/releases/0.3.5/org.eclipse.sisu.plexus/pom.xml

this dependency adds a dependency hell IMHO

why does maven-xml-impl require sisu plexus?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of this class which depends on sisu. It could be moved out of maven-xml-impl I suppose.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class is used in maven-plugin-api unfortunately, so it can't be moved easily into maven-core.

<version>4.0.0-alpha-4</version>
</dependency>
<dependency>
<groupId>org.openjdk.jmh</groupId>
<artifactId>jmh-core</artifactId>
Expand Down
Loading