Skip to content

XML processing instructions with embedded '>' fail to parse #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
toddlipcon opened this issue May 8, 2019 · 1 comment
Closed

XML processing instructions with embedded '>' fail to parse #65

toddlipcon opened this issue May 8, 2019 · 1 comment
Assignees
@michael-o
Milestone
3.2.1

Comments

@toddlipcon
Copy link
Contributor

Commit 7e54bff broke the parsing of multi-line XML processing instructions. For example, the following valid XML file:

<?xml version="1.0" encoding="UTF-8"?>
<project>
  <?pi <tag>
    </tag>
  ?>
</project>

throws:
org.codehaus.plexus.util.xml.pull.XmlPullParserException: processing instruction started on line 2 and column 5 was not closed (position: TEXT seen ...\n <?pi\n ... @3:9)

This causes Maven 3.6 (which uses plexus-interpolation 1.25) to fail to parse some poms which use a multi-line processing instruction as an "ignore" block.
toddlipcon added a commit to toddlipcon/plexus-utils that referenced this issue May 8, 2019
@toddlipcon
Fix parsing of processing instructions containing '>' (issue codehaus…
2450481 
…-plexus#65)
@toddlipcon toddlipcon changed the title Multi-line processing instructions fail to parse XML processing instructions with embedded '>' fail to parse May 8, 2019
@toddlipcon
Copy link
Contributor Author

Turns out it's not multi-line that's an issue, but rather the inclusion of a '>' in the PI content (which is allowed by the XML spec best I can tell)

asfgit pushed a commit to apache/impala that referenced this issue May 10, 2019
@toddlipcon
IMPALA-8516. Update maven for Jenkins builds
327b938 
This changes Maven to download and install on both Ubuntu and Redhat for
the Jenkins builds (previously it was only installed on Redhat).

The version number is kept at 3.5.4 even though a newer release is
available upstream. The new release fails to build Impala due to an
XML-parsing bug causing it to fail to resolve the parquet pom [1]

This should hopefully address some of the hang issues we've seen
previously with the older version of Maven that shipped with the version
of Ubuntu we have on Ubuntu 16.04.

[1] codehaus-plexus/plexus-utils#65

Change-Id: I793409eb4e9f4533b75bfe089a497c0ea62ad1ff
Reviewed-on: http://gerrit.cloudera.org:8080/13268
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Todd Lipcon <[email protected]>
abhir26 pushed a commit to abhir26/Impala that referenced this issue Jun 20, 2019
@toddlipcon @gaallas
IMPALA-8516. Update maven for Jenkins builds
fb51c0c 
This changes Maven to download and install on both Ubuntu and Redhat for
the Jenkins builds (previously it was only installed on Redhat).

The version number is kept at 3.5.4 even though a newer release is
available upstream. The new release fails to build Impala due to an
XML-parsing bug causing it to fail to resolve the parquet pom [1]

This should hopefully address some of the hang issues we've seen
previously with the older version of Maven that shipped with the version
of Ubuntu we have on Ubuntu 16.04.

[1] codehaus-plexus/plexus-utils#65

Change-Id: I793409eb4e9f4533b75bfe089a497c0ea62ad1ff
Reviewed-on: http://gerrit.cloudera.org:8080/13268
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Todd Lipcon <[email protected]>
Reviewed-on: https://gerrit.sjc.cloudera.com/c/cdh/impala/+/49242
Tested-by: Jenkins User <[email protected]>
Reviewed-by: Laszlo Gaal <[email protected]>
Tested-by: Laszlo Gaal <[email protected]>
CDH-Build: Laszlo Gaal <[email protected]>
Quasar-L0: Laszlo Gaal <[email protected]>
abhir26 pushed a commit to abhir26/Impala that referenced this issue Jun 22, 2019
@toddlipcon @cloudera-hudson
IMPALA-8516. Update maven for Jenkins builds
07def7e 
This changes Maven to download and install on both Ubuntu and Redhat for
the Jenkins builds (previously it was only installed on Redhat).

The version number is kept at 3.5.4 even though a newer release is
available upstream. The new release fails to build Impala due to an
XML-parsing bug causing it to fail to resolve the parquet pom [1]

This should hopefully address some of the hang issues we've seen
previously with the older version of Maven that shipped with the version
of Ubuntu we have on Ubuntu 16.04.

[1] codehaus-plexus/plexus-utils#65

Change-Id: I793409eb4e9f4533b75bfe089a497c0ea62ad1ff
Reviewed-on: http://gerrit.cloudera.org:8080/13268
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Todd Lipcon <[email protected]>
@michael-o michael-o self-assigned this Jul 3, 2019
@michael-o michael-o added this to the 3.2.1 milestone Jul 3, 2019
stiga-huang pushed a commit to stiga-huang/impala that referenced this issue Mar 11, 2020
@toddlipcon @stiga-huang
IMPALA-8516. Update maven for Jenkins builds
9f8dd88 
This changes Maven to download and install on both Ubuntu and Redhat for
the Jenkins builds (previously it was only installed on Redhat).

The version number is kept at 3.5.4 even though a newer release is
available upstream. The new release fails to build Impala due to an
XML-parsing bug causing it to fail to resolve the parquet pom [1]

This should hopefully address some of the hang issues we've seen
previously with the older version of Maven that shipped with the version
of Ubuntu we have on Ubuntu 16.04.

[1] codehaus-plexus/plexus-utils#65

Change-Id: I793409eb4e9f4533b75bfe089a497c0ea62ad1ff
Reviewed-on: http://gerrit.cloudera.org:8080/13268
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Todd Lipcon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-o michael-o

Labels
None yet
Projects
None yet
Milestone
3.2.1
Development

No branches or pull requests
2 participants
@toddlipcon @michael-o