Make JarArchiver#createManifest protected #99
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That would allow subclasses of `JarArchiver` to update or inspect the manifest file that is going to be added to the archive.
plamentotev
added a commit
that referenced
this pull request
Sep 22, 2018
That would allow subclasses of `JarArchiver` to update or inspect the manifest file that is going to be added to the archive. Closes #99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no easy way for sub-classes of
JarArchiverto update or inspect the manifest file that is going to be added to the archive. Is there any objections to makeJarArchiver#createManifestprotected so sub-classes have access to the manifest?This change would help with implementing #96. Alternative way is to read the manifest after the jar is created but that would add unnecessary IO.