Skip to content

Update commons compress to 1.15 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update commons compress to 1.15 #72

wants to merge 1 commit into from

Conversation

plamentotev
Copy link
Member

Amongst other things this fixes #57.

@michael-o
Copy link
Member

This should be broken up in two PRs because the issue has existed before but never manifested like this. The contract was the same in 1.14.

Amongst other things this fixes the issues with the
ZIP local headers and central directory entries.

This closes #71, fixes #57
@plamentotev
Copy link
Member Author

ok. I've created #73. After it's merged into master I'll rebase this branch so the test can pass.

@plamentotev plamentotev changed the title Update commons compress to 1 15 Update commons compress to 1.15 Oct 21, 2017
michael-o pushed a commit that referenced this pull request Oct 21, 2017
Amongst other things this fixes the issues with the
ZIP local headers and central directory entries.

This closes #71 and #72, fixes #57.
@michael-o michael-o closed this Oct 21, 2017
@michael-o michael-o self-assigned this Oct 21, 2017
@michael-o michael-o added this to the 3.6 milestone Oct 21, 2017
@plamentotev plamentotev deleted the update-commons-compress-to-1-15 branch February 16, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZipArchiver creates archives with inconsistent central directory entries
2 participants