-
Notifications
You must be signed in to change notification settings - Fork 49
Refactor to use FileTime API #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
61c5766
to
841290a
Compare
src/main/java/org/codehaus/plexus/archiver/AbstractArchiver.java
Outdated
Show resolved
Hide resolved
841290a
to
1c8d25e
Compare
What about tests? Are they implicitly tested? |
Ok, I thought that it was implicitly tested, but it looks that is not, I will add some tests for this and make sure that everything works correctly. Thanks for your input. |
1c8d25e
to
dd0c031
Compare
src/main/java/org/codehaus/plexus/archiver/AbstractArchiver.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/archiver/diags/TrackingArchiver.java
Outdated
Show resolved
Hide resolved
dd0c031
to
793d141
Compare
65d60a4
to
1b89f96
Compare
This should be good to go, I added a test that checks the last modification time of every entry in the zip file in all available Time Zones (although probably with just a couple of them should be enough actually). |
do we really need this noisy bot? |
what about the @InlineMe suggestion: it seems a good idea to prepare about future removal, isn't it? |
That will require adding |
personally I don't think this worth adding a new dependency |
sure, not worth an additional dependency: thanks for evaluating |
1b89f96
to
9a3a5f0
Compare
9a3a5f0
to
f733a8b
Compare
Signed-off-by: Jorge Solórzano <[email protected]>
f733a8b
to
8f5e0ab
Compare
Closes #198
This still preserves backward compatibility with Java 7.