Fix unjustified warning about casing for directory entries

[mthmulders]

Follow-up for #128, where we omitted the case that an archive entry could be a directory. In that case, its name will end with /, but the canonical target path will not have the / suffix. This would be seen as a difference in casing, but that is not true.

[mthmulders]

Thanks, @michael-o for the review. I don't have the rights to merge this PR, I'd be grateful if someone who does have the rights can merge it for me.

[mthmulders]

@michael-o I see a lot of Maven components already updating Plexus Archiver, with this little issue still present. Shouldn't we try to merge this in, too, given the false warnings that'll occur otherwise?

[plamentotev]

@mthmulders would you please squash the commits into one and I'll merge it.

[mthmulders]

@mthmulders would you please squash the commits into one and I'll merge it.

Squashed & force-pushed. Thanks in advance :-)

[plamentotev]

The build is failing after the merge. I'll check it later today

[mthmulders]

Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project plexus-archiver: Execution default-compile of goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile failed: Plugin org.apache.maven.plugins:maven-compiler-plugin:3.8.1 or one of its dependencies could not be resolved: Could not transfer artifact org.apache.maven.shared:maven-shared-incremental:jar:1.1 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-shared-incremental/1.1/maven-shared-incremental-1.1.jar: Connection reset -> [Help 1]

My guess is that's unrelated to the code change, but feel free to investigate further and let me know if you draw a different conclusion.

[michael-o]

Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project plexus-archiver: Execution default-compile of goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile failed: Plugin org.apache.maven.plugins:maven-compiler-plugin:3.8.1 or one of its dependencies could not be resolved: Could not transfer artifact org.apache.maven.shared:maven-shared-incremental:jar:1.1 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-shared-incremental/1.1/maven-shared-incremental-1.1.jar: Connection reset -> [Help 1]

My guess is that's unrelated to the code change, but feel free to investigate further and let me know if you draw a different conclusion.

Correct, is an ephemeral network issue. Restart or check your internet connection.

[plamentotev]

@mthmulders I've released a new version with this fix. Thanks for contributing.

[mthmulders]

Thank you for considering this contribution and for releasing a new version so quickly.