Modify ModularJarArchiver to use the manifest main class as default #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the main class for a module is not explicitly set, lets use the one specified in the manifest file. That would simplify the creation of modular JAR files - clients should just set the manifest main class as in non-modular JAR file and everything will work out of the box. Also it will allow `ModularJarArchiver` to be used as drop-in replacement of `JarArchiver` without any additional configuration.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the main class for a module is not explicitly set, lets use the one specified in the manifest file. That would simplify the creation of modular JAR files - clients should just set the manifest main class as in non-modular JAR file and everything will work out of the box. Also it will allow
ModularJarArchiverto be used as drop-in replacement ofJarArchiverwithout any additional configuration.