#20: Manifest#write blindly casts bytes to chars

michael-o · michael-o · commit ef2902daa1f6 · 2016-05-21T02:00:21.000+02:00
This closes #20
diff --git a/src/main/java/org/codehaus/plexus/archiver/jar/Manifest.java b/src/main/java/org/codehaus/plexus/archiver/jar/Manifest.java
@@ -849,10 +849,8 @@ public void write( Writer writer )
     {
         ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();
         super.write( byteArrayOutputStream );
-        for ( byte b : byteArrayOutputStream.toByteArray() )
-        {
-            writer.write( (char) b );
-        }
+        // We know that UTF-8 is the encoding of the JAR file specification
+        writer.write( byteArrayOutputStream.toString( "UTF-8" ) );
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -849,10 +849,8 @@ public void write( Writer writer )`
`849`	`849`	`{`
`850`	`850`	`ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();`
`851`	`851`	`super.write( byteArrayOutputStream );`
`852`		`- for ( byte b : byteArrayOutputStream.toByteArray() )`
`853`		`- {`
`854`		`- writer.write( (char) b );`
`855`		`- }`
	`852`	`+ // We know that UTF-8 is the encoding of the JAR file specification`
	`853`	`+ writer.write( byteArrayOutputStream.toString( "UTF-8" ) );`
`856`	`854`	`}`
`857`	`855`
`858`	`856`	`/**`