#17: Remove unnecessary conversion in Manifest#Attribute#write

michael-o · michael-o · commit d93fa7cd38ed · 2016-05-21T01:35:30.000+02:00
This closes #17
diff --git a/src/main/java/org/codehaus/plexus/archiver/jar/Manifest.java b/src/main/java/org/codehaus/plexus/archiver/jar/Manifest.java
@@ -308,17 +308,10 @@ public void addValue( String value )
         void write( Writer writer )
             throws IOException
         {
-            StringWriter sWriter = new StringWriter();
-            PrintWriter bufferWriter = new PrintWriter( sWriter );
-
             for ( String value : values )
             {
-                writeValue( bufferWriter, value );
+                writeValue( writer, value );
             }
-
-            byte[] convertedToUtf8 = sWriter.toString().getBytes( "UTF-8" );
-
-            writer.write( new String( convertedToUtf8, "UTF-8" ) );
         }
 
         /**

Original file line number	Diff line number	Diff line change
`@@ -308,17 +308,10 @@ public void addValue( String value )`
`308`	`308`	`void write( Writer writer )`
`309`	`309`	`throws IOException`
`310`	`310`	`{`
`311`		`- StringWriter sWriter = new StringWriter();`
`312`		`- PrintWriter bufferWriter = new PrintWriter( sWriter );`
`313`		`-`
`314`	`311`	`for ( String value : values )`
`315`	`312`	`{`
`316`		`- writeValue( bufferWriter, value );`
	`313`	`+ writeValue( writer, value );`
`317`	`314`	`}`
`318`		`-`
`319`		`- byte[] convertedToUtf8 = sWriter.toString().getBytes( "UTF-8" );`
`320`		`-`
`321`		`- writer.write( new String( convertedToUtf8, "UTF-8" ) );`
`322`	`315`	`}`
`323`	`316`
`324`	`317`	`/**`