Add SkeletonAnimation and GLProgram to the list of extendable classes.

[IgorMats]

Hi.

In my case it was very useful to add SkeletonAnimation and GLProgram to the list of extendable classes...

For GLProgram extend I've added only cc.GLProgram.extend = cc.Class.extend, but it was very hard to extend SkeletonAnimation class:

This branch:

1. I have added SkeletonAnimation to the list of extendable classes;

Cocos2d-x branch:

1. I've made empty constructor of SkeletonAnimation visible (public);
2. I've added initWithFiles method which will be called from:
3. I've added _ctor function.

What do you think about it?

Thank you!

[IgorMats]

Build was failed because cocos2d-x branch need to merge this pull request: cocos2d/cocos2d-x#9199

[pandamicro]

Please create frameworks/js-bindings/bindings/script/jsb_spine.js file and put all related scripts there, for package division purpose we need to separate scripts for different modules

[pandamicro]

Please do not commit anything under frameworks/js-bindings/bindings/auto/. All auto bindings will be generated automatically by our cocos robot account.

[IgorMats]

Hi @pandamicro.

Please take a look at the fixed implementation.

Thanks.

[pandamicro]

It should be ok, can you add a test case for it ? We can't merge any feature without a test case

[IgorMats]

Yeah, I will do it ASAP.

[pandamicro]

As it won't work unless the C++ API get bound, I'm not sure it worth your time now to create a test case

[IgorMats]

@pandamicro, okay. I will try to send pull request to the spine runtimes repository first.

[IgorMats]

@pandamicro, or maybe you can suggest how we can solve this on javascript level? Because I not understand yet how we can bind class with protected empty constructor.

[pandamicro]

In fact, we used CC_CONSTRUCTOR_ACCESS macro for constructors and init functions, the value is protected in Cocos2d-x, but public in Cocos2d-JS

[IgorMats]

It's ok, but current version of SkeletonAnimation.h in Cocos2d-x is using protected instead of CC_CONSTRUCTORS_ACCESS: https://github.com/cocos2d/cocos2d-x/blob/v3/cocos/editor-support/spine/SkeletonAnimation.h. Is this a mistake?

[pandamicro]

I think that Spine guys haven't taken account of JSB needs when they implement it.

[IgorMats]

Sure! Therefore, we return to the previous question.

[pandamicro]

I think you mean: how we can bind class with protected empty constructor.

We can't, all protected functions are ignored by bindings generator

[IgorMats]

So it's mean that if we can't change protected to CC_CONSTRUCTOR_ACCESS we can't extend class in JSB?

Spine runtime do not accept that changes.

In that case I don't know what can I do with it.

[pandamicro]

Can you give the link of the discussion?

[IgorMats]

@pandamicro sorry, it was just my guess.

I created a pull request at spine-runtimes repo: EsotericSoftware/spine-runtimes#333 but as @NathanSweet wrote he is will travel a few weeks and can not accept any pull requests.

[IgorMats]

@pandamicro

Hi. So, @NathanSweet closed my pull request. Can we move forward with my feature request? Thanks.

[pandamicro]

Yes, I saw it, finally. I will try to sync spine runtime for Cocos2d-x tomorrow then we can finally get to this PR. Really appreciate your effort

[pandamicro]

@IgorMats I have a question about your modification,

Why are you skipping the default initialize in both SkeletonAnimation and SkeletonRenderer ?

[IgorMats]

@pandamicro I don't remember exactly. It was a too long time ago) Sorry.

[IgorMats]

I think there was a some problem related to the empty constructor and priority of calling constructor, setSkeletonData and initialize methods.

[pandamicro]

Hi, @IgorMats I have updated Cocos2d-x with the modifications you pushed to Spine

#1438

Now can you fix the compilation issue in Travis ? I think pull the latest repo can fix it.

[IgorMats]

Hi, @pandamicro thanks. I'm alredy do it right now. I will finish ASAP.

[IgorMats]

@pandamicro ok, so build was successful. Now I will try to add some test case.

[IgorMats]

@pandamicro I tested it on our company project just now and it works like a charm for both: Android, iOS and Web.

Now, can your tell me please what kind of test I must to implement?
It should be just test of extends?

Thanks.

[pandamicro]

Great ! You are so efficient !
You can add some test case to samples/js-tests/src/SpineTest/SpineTest.js
Now we only have one scene with two animations, if you like you can add some more if there is no issue with the copyright of the resources. For testing extend, just do it in the way you use in your project.

[pandamicro]

If you can do it within one day, I think I can merge it into 3.3, because it's supposed to be released by the end of this week.

[IgorMats]

OK, I will do it today. Thanks.

[IgorMats]

@pandamicro sorry, but I can't do it today. Now we have some active hostilities in our country :(

[pandamicro]

Hang in there man ! I want you to know that the cocos team are all with you !
Don't worry about the PR, I will add some test for it.
I wish the war in Ukraine will soon be finished, let Ukraine people suffer less and let's build something useful with our code !

[IcePower2012]

@IgorMats 小伙子加油! Hope the world will be peace!

[pandamicro]

@IgorMats I added the test case and it works like a charm !
#1444

[0716wenzheng]

Everything will be ok

[kyoshiwoa]

my first message ,Good Luck for you and your family!

[IgorMats]

Oh, thank you guys! Now we have a big problem with safety, but I will try to continue work on cocos2d-js.

@pandamicro thank you for completion of my PR. I apologize that I could not finish it myself.

[pandamicro]

It's totally ok, we really appreciate your effort on Cocos2d-JS ! Take care and be safe !

[yunfeige]

I admire you, and Thanks!