-
Notifications
You must be signed in to change notification settings - Fork 905
739 stackable actions #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, Robert Boyd. |
Bonus point for supporting stackable actions also in |
Hi, this fix has unexpected side effects for us |
@timmjd That's right, this is a breaking change. You will need to stop any current actions on the target before running new actions to achieve the old behavior. The only other option I see is to offer a setting to enable/disable stackable actions at runtime and leave them disabled by default, but in achieving parity with cocos2d-x, that ship may have already sailed. @ricardoquesada and @linshun may have some thoughts on this. At the very least we should be sure to capture this change in the release notes. |
This is my take: stackable actions for position should be implemented 0% or a 100%. Right now it is 40% and it will confuse users. Implemented: The expected behavior should be to support "stackable" actions. And yes, it is not backward compatible. Since this fix was introduced just a few days before the release, it is incomplete (3 actions are missing), and cocos2d-x does not support it, my suggestion is to remove this feature from this release, and for the next release add support for all 5 actions in both on cocos2d-html5 and cocos2d-x |
I agree that stackable actions should be all or nothing when targeted for a release. I'm out of touch with how the release process works on this project. I will set aside some time this weekend to work on the curve functions. As an aside: where does most of the developer discussion take place on this project and cocos2d-x in general? Is it on the forum? |
@rboyd: We are discussing everything here: |
We plan to add the rest of stackable actions and cc.FileUtils this Sunday Morning. If we can't finish it. As Riq's suggestion, I will remove all of stackable actions provisionally. |
#753 implements Bezier and Catmull/Cardinal. Everything looks fine from my testing. |
@ricardoquesada is RotateTo also meant to stack? |
@rboyd: Good question. I am not sure if the For sure, I would not include them for this release. |
No description provided.