Skip to content

web UIButton support BMFont #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2017
Merged

web UIButton support BMFont #3497

merged 1 commit into from
Sep 22, 2017

Conversation

continuemycoding
Copy link
Contributor

@pandamicro
Copy link
Contributor

Thanks for your contribution ~

@pandamicro pandamicro merged commit 9eb6a3d into cocos2d:develop Sep 22, 2017
@pandamicro pandamicro mentioned this pull request Sep 22, 2017
Merged
@pandamicro
Copy link
Contributor

pandamicro commented Sep 22, 2017 •
edited
Loading

Sorry, I thought I can adjust internal usage of _titleRenderer quickly, but in fact I realize there are much code to modify and to test, we are during QA test of 3.16, it's not a good time.

So I revert your PR

If you want to merge this functionality, please add _type in UIButton, and review all usage of _titleRenderer, then invoke different methods for different types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@continuemycoding @pandamicro