Skip to content

Enable support of retina displays #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2017
Merged

Conversation

1scaR1
Copy link
Contributor

@1scaR1 1scaR1 commented Mar 7, 2017

It seems to be ok to enable retina support.
I don't why it was disabled at all...

@pandamicro
Copy link
Contributor

Actually this macro is never used and never set, cc.view.isRetinaEnabled() is the correct API, we haven't cleanup these macros

@1scaR1
Copy link
Contributor Author

1scaR1 commented Mar 8, 2017

It's actial use in cc.contentScaleFactor function. If this macro is set to 0 then this functions always returns 1.
In actual code it breaks compability with jsb on retina displays, because 'setContentScaleFactor' not works.
If you want to remove this macro my propose is to set cc.contentScaleFactor always to return Director's _contentScaleFactor in this PR. Is it right?

@pandamicro
Copy link
Contributor

If you want to remove this macro my propose is to set cc.contentScaleFactor always to return Director's _contentScaleFactor in this PR. Is it right?

I think it would be more proper

@1scaR1
Copy link
Contributor Author

1scaR1 commented Mar 8, 2017

@pandamicro Done! Please, review

@pandamicro pandamicro merged commit fa8edd4 into cocos2d:develop Mar 8, 2017
@pandamicro
Copy link
Contributor

Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants