Fix: doEnumerateRecursive(node, name, callback) now returns the return value. #3384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also fixed a typo in the setBoundarySet function (it was missing the letter 'n'). |
… cc.Scheduler namespace for consistency with PRIORITY_SYSTEM.
|
I also fixed an apparent typo which caused the PRIORITY_NON_SYSTEM constant to be NaN. It is used nowhere else in the code base, so it seems like an easy fix. |
ronyeh
changed the title
pandamicro
approved these changes
Dec 6, 2016
|
Thank you and sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the return value "ret" was unused.
I added a line to return "ret" at the end of the function.