HiDPI support in CCLabelTTF #3294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ntrrgc Thanks for the contribution, it's a very intelligent solution ~ |
|
Mmm now labels returns incorrect contentSize of them.(On retina(MacBook or iPad) twice more then they are) |
|
Yep, I was worried of this kind of issues. Fixing that one would be a matter of overriding one more method. On the other hand, I haven't checked affine transformations other than scaling (how many does cocos2D support?). Depending on how they are implemented, labels using them may break too, case in which we may have to come with another solution. |
|
Ideally the size of the texture and the unscaled logical size of the sprite should be allowed to be different to support different image depths. |
|
@1scaR1 Issue fixed in new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds built-in HiDPI support to text labels, so you don't have to double font size and scale them down manually in order to have crisp text rendering in high resolution mobile devices.