Refactor ccui.ScrollView,ListView,PageView to correspond cocos2d-x v3.11 api. #3193
Conversation
1scaR1
changed the title
1scaR1
changed the title
|
Synced with HEAD of cocos2d-x |
|
@1scaR1 Could you add some tests to verify your patch? I have fetched your patch and it works great with the old tests. |
| "extensions/ccui/uiwidgets/scroll-widget/UIScrollView.js", | ||
| "extensions/ccui/uiwidgets/scroll-widget/UIListView.js", | ||
| "extensions/ccui/uiwidgets/scroll-widget/UIPageView.js", | ||
| "extensions/ccui/uiwidgets/scroll-widget/UIPageViewIndicator.js", | ||
| "extensions/ccui/uiwidgets/scroll-widget/UIPageView.js", |
There was a problem hiding this comment.
"extensions/ccui/uiwidgets/scroll-widget/UIPageView.js", this line is duplicated.
|
Duplication is fixed. Js-test are in progress. |
-fixed anchor point in PageView -fixed z oder of indexed items in PageViewIndicator
|
Added js-tests cocos2d/cocos2d-x#15398 Some bugs were fixed with these tests :) |
|
@1scaR1 Thanks, could you fix the merge conflicts? After the merge conflicts is fixed, I will merge your PR |
…to develop # Conflicts: # extensions/ccui/uiwidgets/scroll-widget/UIPageView.js Conflicts resolved.
|
Conflict resolved. Thanks! |
|
@1scaR1 👍 merged. |
|
@1scaR1 Yes, it fixed the issue for me (WebGL render). Thanks ! |
|
@zilongshanren @1scaR1 Version 3.11 had just been released and the fix is not included, why ? |
|
@ppawlak Maybe you could apply it to v3.11 by yourself . |
|
@zilongshanren That's what I did, it's a trivial fix to apply. Problem is for other people not aware of it... I just found an other issue with the ListView: http://discuss.cocos2d-x.org/t/cocos2d-x-v3-11-released/29253/14?u=nemoidstudio |
I think api in html5 version is too old to use it in pair with cocos2d-x 3.9 lib(with js-bindings).
So i changed it using code base of cocos2d-x classes.