-
Notifications
You must be signed in to change notification settings - Fork 2
Create geo-aggregation extension of tsibble and demonstrate its use in aggregation vignette #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For the full discussion that this issue is based on, see cmu-delphi/epiprocess#7 |
Here is some context for what we are interested in achieving. The idea sketched out here would be to create a class that inherits from Consider this example from the
If one wanted to aggregate to the This is directly analogous to how
An example: Suppose
Here Obviously, instead of |
@ryantibs @jacobbien I'm happy to take this task if it's still open. Also happy to help with any issues I've created with my previous PR as well. |
@qpmnguyen Sounds good! Let's discuss on slack what the best approach is, because there is a lot of functionality already written (for our indicators pipeline) for geo aggregation stuff in Python, which is in the There's also some smaller issues I'm about to open if that slack discussion takes a while to resolve on what's the best strategy. I'll point you to this when I open them. Re your time aggregation PR: I'm just finishing going through it now, should be able to merge it soon. |
As a follow-up, I only opened up one tiny issue cmu-delphi/epiprocess#39, the other one I managed to figure out and fix already. Your PR is merged. Thanks again! |
Sounds good! I'll take a look at the indicators Repo and draft up some discussion points in Slack. |
@qpmnguyen Do we have a repo yet for |
@ryantibs I just transferred the issue! I have a branch working locally on my fork and will initiate a pull request once more things have been added. |
The basic idea here is to do for geography what
tsibble
does for time. I will elaborate on this below. In particular, a key outcome of this issue would be to demonstrate geographic aggregation functionality in the second half of theaggregate.Rmd
vignette. But unlike in cmu-delphi/epiprocess#24, where the only task was to write the demo, in this case one would first need to actually develop the geographic aggregation functionality itself. I sketch out here a particular approach to this, which would involve writing a new separate R package that would inherit fromtsibble
, as described below.The text was updated successfully, but these errors were encountered: