Skip to content

One more simple example for getting start guide #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryantibs opened this issue Feb 9, 2022 · 9 comments
Closed

One more simple example for getting start guide #39

ryantibs opened this issue Feb 9, 2022 · 9 comments
Assignees

Comments

@ryantibs
Copy link
Member

ryantibs commented Feb 9, 2022

We should add more more example at the bottom of the getting started guide (there's a "todo" at the bottom to mark the spot).

I'm thinking it'd be nice to have one more example just getting some data into epi_df format and then plotting it. Can be something from the outbreaks package, or something from the web somewhere (but not from covidcast).

cc @rafaelcatoia @qpmnguyen In case you guys are interested.

@rafaelcatoia
Copy link
Contributor

@ryantibs, I can do it.

I tried to install the package as indicated in the getting started guide but I get what seems to be a permission error related to delphi-epidata-r . I also tried to install delphi-epidata-r separately and got a different error:

Error in grepl(e, files, perl = TRUE, ignore.case = TRUE) : 
   invalid regular expression '^\Makefile$' 

Is that expected to happen and I should manually run the functions?

@ryantibs
Copy link
Member Author

Thanks!

Re that error: my guess is that it's because of these two lines at the bottom of the DESCRIPTION file:

Suggests:
    delphi.epidata
Remotes:
    github:cmu-delphi/delphi-epidata-r

I think that was added by @lcbrooks but it's possible there was a merge conflict somewhere that messed them up. So you could either fix the reference to the delphi-epidata-r repo (should be fine, since it's a public repo) in the DESCRIPTION, or simply remove these two lines from the DESCRIPTION, since at the moment we don't need the delphi.epidata package at all in any of the examples/vignettes.

Either way, you could commit this change to your PR with the new example, and then when we merge it in, it'll fix main as well.

@ryantibs
Copy link
Member Author

By the way, you could just build the package locally, and you shouldn't get that problem --- I have never gotten that problem with a local build, but I did recreate that problem by calling devtools::install_github().

@lcbrooks
Copy link
Contributor

lcbrooks commented Feb 10, 2022 via email

@rafaelcatoia
Copy link
Contributor

Thanks, I'm running it locally and I'll let you know when I'm done

@rafaelcatoia
Copy link
Contributor

@ryantibs, can you give me permission to push to the repo?

@ryantibs
Copy link
Member Author

Sure, I just gave you write access. Just so you know, you should be able to create a fork and submit a PR even without write access.

And in any case you should always be creating a branch (or fork) and submitting a PR for new developments, in case that wasn't clear. Thanks!

@rafaelcatoia
Copy link
Contributor

Great, thanks. I cloned and created a new branch and now I'll open the PR.

@rafaelcatoia rafaelcatoia self-assigned this Feb 15, 2022
@ryantibs
Copy link
Member Author

Closed via #43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants