Skip to content

feat: add covid hospitalizations production pipeline #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Apr 10, 2024

Fix #39. Took a while to get the metaprogramming bits right. A few smaller details left:

  • plotting notebook
  • need to double check that we're using the right forecaster with the right params

Roll out plan:

  • clone this on the production machine
  • set a cronjob to run this targets pipeline ahead of the legacy pipeline
  • read the targets object directly in the daily pipeline and integrating it into the plotting
  • once we're convinced it can be used to replace the existing pipeline, we can deactivate the legacy pipeline and migrate the other bits here (plotting, slack posting)

@dshemetov dshemetov requested a review from dsweber2 April 10, 2024 01:03
@dshemetov dshemetov marked this pull request as ready for review April 11, 2024 20:20
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! There's a range of things, but the only hold-ups are the things I actually made suggestions on, and how to handle the exclusion date.

Not sure how seriously to take plotting specific problems, if we're actually just using the results in a different place for now.

@dshemetov dshemetov requested a review from dsweber2 April 23, 2024 23:48
@dshemetov dshemetov requested a review from dsweber2 April 24, 2024 01:30
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should've said approved earlier

@dshemetov dshemetov merged commit 14d99f1 into main Apr 24, 2024
1 check passed
@dshemetov dshemetov deleted the ds/covid-prod branch April 24, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate covid-hosp-forecast production forecasts
2 participants