Skip to content

testing: ab testing branch for epiprocess r6 refactor #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024

Conversation

dshemetov
Copy link
Contributor

Companion branch for cmu-delphi/epiprocess#431.

Reduces the covid_hosp_explore project to a subset of the forecasters for faster comparison. I found no differences in the forecast outputs. See the r6_refactor.R script for instructions for how to replicate.

@nmdefries
Copy link
Contributor

nmdefries commented Apr 4, 2024

My run is failing here. Looks like the as_of function is supposed to come from epiprocess, so it should be @importFromed epiprocess above and docs rebuilt.

Edit: Hmm, getting ✖ looping.R:26: @importFrom Excluding unknown export from epiprocess: 'as_of'. when I try this locally.

@dshemetov
Copy link
Contributor Author

dshemetov commented Apr 4, 2024

Ah right, so that's a line changed in this PR's branch and it dispatches to as_of.epi_archive on the refactor branch. The current live exploration-tooling+epiprocess combo uses epi_archive$as_of (which is the old R6 method for doing as_of on archives). Iirc this was the only line I had to refactor in exploration-tooling to get the refactor branch to work.

@dshemetov
Copy link
Contributor Author

dshemetov commented Apr 10, 2024

Try these:

# A branch
pak::pkg_install("cmu-delphi/exploration-tooling@ds/epiprocess")
pak::pkg_install("cmu-delphi/epiprocess@ds/r6-clean")


# B branch
pak::pkg_install("cmu-delphi/exploration-tooling@main")
pak::pkg_install("cmu-delphi/epiprocess@dev")

@nmdefries
Copy link
Contributor

Thanks, will try these branch combos.

@dshemetov dshemetov requested a review from nmdefries April 26, 2024 22:15
* save comparison script from ab testing
@dshemetov dshemetov merged commit 150d876 into main May 8, 2024
1 check passed
@dshemetov dshemetov deleted the ds/epiprocess branch May 8, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants