Km compactify refiled #97
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side this project.
brookslogan
requested changes
Jun 7, 2022
There was a problem hiding this comment.
Nice approach to finding LOCF-redundant values in a highly vectorized manner without requiring any potentially-expensive dplyr/data.table grouping operations (although some of those can be extremely quick as well). There are still some essential things needing to change (e.g., roles of time_value and version are flipped, other non-version keys aren't considered, annoyances regarding NAs in the DT). I've discussed these in more detail in the PR code comments below.
|
Superseded by #101; closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.