-
Notifications
You must be signed in to change notification settings - Fork 8
add more complex slide example #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Awesome, thanks Dan! This is fast work, and great. I'm not worried about either of your bullet points, though thanks for pointing them out. (However, I'm not sure what you meant by "After that, they do whatever"? Worth elaborating? Or not important?) Re your two questions:
Now a few small requests before the merge:
|
I made the graph and managed to rebuild. Those are pretty ugly predictions! On the questions: I'll take care of 1. For 2. I meant "ordered" (somehow missed the arrange call). And I don't think it's worth worrying about the other bullet. |
@dajmcdon Awesome! I was just looking through the code now and these are nice examples of slide indeed. Couple more things come to mind. (Sorry to drag this out ...)
|
- Scrap baseline forecaster for now - Refactor AR implementation to use tidy code - Add a bit more discussion surrounding the AR model's behavior - Other small fixes/copyedits to vignettes - Add Dan as a contributor
I managed to finish off the AR example just now (last commit message give some details). Thanks @dajmcdon for the great work here. |
epi_slide `f` parameter documentation
Closes #5.
Added two "local forecasters" to the vignette.
Both do arbitrary aheads. A few notes:
min_train_window
argument in both functions that returnsNA
forecasts if the slide window is not long enough yet. After that, they do whatever. This seemed easiest to illustrate the behavior without too much data processing that would be needed in a real forecaster. Let me know if you have a better idea. I didn't bother to filter out theNA
s this induces at the beginning of the series, but that doesn't seem key to the illustration either.Two things that occur to me related to #7 :
time_values
?tsibble::fill_gaps()
fixes this, but I couldn't tell if it's part of the class.time_values
? Not clear to me iftsibble
does this. But maybe we should?