Skip to content

Fix validate_version_bound typo #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

brookslogan
Copy link
Contributor

@brookslogan brookslogan commented Oct 1, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • [-] Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Make sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • [-] Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

This fixes a typo that appears to have no impact, but might confuse us in the future. The impacted x_arg never actually seems to be used, so maybe something else should be done but I'm not looking too much into it.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@brookslogan brookslogan requested a review from dshemetov October 1, 2024 00:01
@brookslogan brookslogan force-pushed the lcb/fix-version-bound-typo branch from 73cd78b to c801560 Compare October 1, 2024 00:44
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but a few minor comments. Approving so you can merge after whatever fixes you decide on.

Co-authored-by: Dmitry Shemetov <[email protected]>
@brookslogan brookslogan merged commit 2c7b77c into dev Oct 2, 2024
3 checks passed
@brookslogan brookslogan deleted the lcb/fix-version-bound-typo branch October 2, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants