Lcb/slide unnest dedupe cols #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving from `group_modify` to `group_map` means doing our own labeling. Handle a corner case here in a way similar to `group_modify` (if you think of `version` being a non-dropping factor at the beginning of the grouping columns). It's not clear this behavior is what we want... perhaps we want to generate errors if we ever have NAs generated from this not-a-nondropping-factor version/grouping-column following a nondropping-factor version/grouping-column. Or at least warn in the subcase of this when a user requests an empty version when `.drop = TRUE` or `.drop = FALSE` but there are nonfactor columns. Tweak the `.drop = FALSE` warning that tries to ward against some of the above cases (but is only thinking about grouping columns rather than version + grouping columns) so that it won't warn if there are 0 grouping columns. It makes sense that a user may have a set of potential factor grouping columns and programmatically try models with different grouping column sets and `.drop = FALSE`, including an empty grouping column set.
4 tasks
|
Related #509 |
4 tasks
This has the core of the concept, but geo-grouped epi_slides will decay to tibble due to the move from group_modify -> group_map without reconstructing afterward. But planned changes to use `.keep = TRUE` should also serve to address this issue.
See #475. We have the ability to catch this consistently now since we are using `.keep = TRUE`, so the .x into each slide computation is an `epi_df` even if we're grouping by `geo_value` (previously, .x would have decayed into a tibble and we shouldn't override tibble's behavior). Also add missing `group_map` import.
brookslogan
force-pushed
the
lcb/slide-unnest-dedupe-cols
branch
from
d209619 to
e1d300d
Compare
dshemetov
reviewed
Sep 13, 2024
|
Merging now as this has the essentials for rebasing 519. Cleanup to proceed off of slide improvements branch. Will migrate in some way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
epi_slide*no column behavior #475TODO
epi_slidecol dedupe