Skip to content

Arrange cannonical #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 21, 2024
Merged

Arrange cannonical #511

merged 15 commits into from
Aug 21, 2024

Conversation

dajmcdon
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).

Change explanations for reviewer

  • Makes new_epi_df() column order match key_colnames() ordering.
  • Adds an internal function to locate columns in canonical order, and arrange rows in that order. Resolves epi_df structure #482
  • Cleans up some Roxygen documentation that was producing warnings/notes in R CMD Check

@dajmcdon
Copy link
Contributor Author

@dsweber2 Can you take a look at the snapshot errors in the check above? This PR shouldn't touch those, so I'm not sure what's right or wrong.

@dsweber2
Copy link
Contributor

It's changing the default order of the columns, so the snapshot is getting put in a different order. The actual content of the tibble is the same, I checked. I just pushed a commit that records that.

@brookslogan brookslogan merged commit 8dff011 into dev Aug 21, 2024
3 checks passed
@brookslogan brookslogan deleted the arrange-cannonical branch August 21, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

epi_df structure
3 participants