Skip to content

minor bug fixes to outlier detection #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Conversation

elray1
Copy link
Collaborator

@elray1 elray1 commented Feb 25, 2022

  • add validation that x does not contain duplicate values to detect_outlr. This resolves the part of Issue validation for correct grouping structure #26 that relates to this function.
  • prevent error when calling detect_outlr without having explicitly loaded the tibble package by using tibble::... when constructing a default argument value
  • take more care when standardizing names of components returned by feasts::STL; hopefully will be more robust across versions of feasts (name of the seasonal column changed between the time I wrote this and now).
  • prevent error in dplyr::case_when with disagreeing data types
  • update outliers vignette so that the seasonal STL method uses seasonality; it got lost at some point
  • add some (very) minimal unit tests for expected errors from detect_outlr

@ryantibs
Copy link
Member

Looks good, thanks! I notice that you still are working in your old epitools repo clone. I will go ahead and merge.

Git is repointing this to the newly renamed epiprocess repo, but I think it would be safer (fewer potential problems downstream) if you just nuked and re-cloned epiprocess, assuming you don't have un-pushed work.

@ryantibs ryantibs merged commit 59be7d5 into cmu-delphi:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants