-
Notifications
You must be signed in to change notification settings - Fork 8
Generalize optimized epi_slide
fn
#433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f4ff336
to
4f4a67a
Compare
237fc38
to
0125bee
Compare
9fd90e7
to
ddc1934
Compare
6e6d198
to
1385d59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than this bit with slider seems good
Co-authored-by: David Weber <[email protected]>
Looks like the linter and styler disagree about the spacing for this:
so I guess the linter is going to fail indefinitely. Disappointing and weird. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wait for Logan to get back? Wouldn't put it past him to have some arcane solution to the identical
vs all.equal
problems. I'd be fine with leaving that as an open issue for a potential future feature though. Actually using anons is mostly covered by passing args.
David opened an issue RE styler here Will have Logan take a look at this when he gets back, but if it needs changes, I'll do those in a separate PR. I don't want this to be hanging as a PR for a long time. |
|
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION
. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
Make
epi_slide_mean
more general. Let the user pass adata.table
rolling fn (frollmean
,frollsum
,frollapply
) orslider
rolling function (slide_sum
, etc) to expand optimized slide functionality.