Skip to content

lint: copy .lintr from epidatr #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024
Merged

lint: copy .lintr from epidatr #414

merged 1 commit into from
Feb 1, 2024

Conversation

dshemetov
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epiprocess main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).

Change explanations for reviewer

  • Mostly line length 120, cyclocomp off
  • Repo changes, no need for changelog/version

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@dshemetov dshemetov requested a review from nmdefries February 1, 2024 21:02
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. How does this get run?

@dshemetov
Copy link
Contributor Author

If you have an IDE linter or if you do lintr::lint_package() it should automatically get read. Nothing automated or in CI at this point.

@dshemetov dshemetov merged commit 44486f9 into dev Feb 1, 2024
@dshemetov dshemetov deleted the ds/lint branch February 1, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants