Test autoplot and arg-checker functions #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r didn't pass col names
Using an external vector in selections was deprecated in tidyselect 1.1.0. i Please use `all_of()` or `any_of()` instead. # Was: data %>% select(geo_and_other_keys) # Now: data %>% select(all_of(geo_and_other_keys))
|
Woops, I just saw you made this PR after merging #410, my bad. I removed some of the functions you're testing here, sorry to null that work but on the plus side we don't need to unit test checkmate functions. |
|
I was expecting the issue to use checkmate functions to disappear into the issue void :P Would have been less work overall if I'd started there instead of the tests. |
dajmcdon
approved these changes
Jan 27, 2024
|
Hehe yea, reasonable :) I was particularly excited about that issue cause checkmate was very satisfying to implement in epidatr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.