fixing constant check warnings

[dsweber2]

whenever I run check locally, I get a lot of errors about various documentation bits missing. This fills those in.

Closes #132 apparently.

[brookslogan]

Looks good; see minor request above + please check/correct my tweaks before merging.

[brookslogan]

This will close #132.

[brookslogan]

Great, you worded that documentation prose line wrong and now look what happens

   Processing triggers for install-info (6.8-4build1) ...
  NEEDRESTART-VER: 3.5
  NEEDRESTART-KCUR: 6.2.0-1018-azure
  NEEDRESTART-KEXP: 6.2.0-1018-azure
  NEEDRESTART-KSTA: 1
  Error: 
  ! error in pak subprocess
  Caused by error in `verify_extracted_package(filename, pkg_cache)`:
  ! 
  '/tmp/RtmpJscovc/file135b521262ed/src/contrib/x86_64-pc-linux-gnu-ubuntu-22.04/4.3/withr_3.0.0.tar.gz'
  is not a valid binary, it is missing withr/Meta/package.rds.
  ---
  Backtrace:
  1. pak::lockfile_install(".github/pkg.lock")
  2. pak:::remote(function(...) { …
  3. err$throw(res$error)
  ---
  Subprocess backtrace:
   1. base::withCallingHandlers(cli_message = function(msg) { …
   2. get("lockfile_install_internal", asNamespace("pak"))(...)
   3. plan$install()
   4. pkgdepends::install_package_plan(plan, lib = private$library, num_workers = nw, …
   5. base::withCallingHandlers({ …
   6. pkgdepends:::handle_events(state, events)
   7. pkgdepends:::handle_event(state, i)
   8. proc$get_result()
   9. processx:::process_get_result(self, private)
  10. private$post_process()
  11. pkgdepends:::install_extracted_binary(filename, lib_cache, pkg_cache, lib, …
  12. pkgdepends:::verify_extracted_package(filename, pkg_cache)
  13. base::throw(pkg_error("{.path {filename}} is not a valid binary, it is missing {…
  14. | base::signalCondition(cond)
  15. global (function (e) …
  Execution halted
  Error: Process completed with exit code 1.

[dsweber2]

I may have blamed the wrong source of the check errors it seems. Any idea why this is happening? I remember this sort of build error happening like 1/20 times or fewer on other repos, but this is like 1/2 or 3/4...

[brookslogan]

Oh, I haven't seen it before! I'm not sure why. I'm trying some stuff out locally but no luck getting something similar so far.

Aside: could you please add NEWS.md entries for this + the select stuff, or add an Issue reminding us? We should probably put in some reminder to do this on PR creation.

[brookslogan]

Force push was for styling. Think this is ready to merge. Just waiting for check completion.