Skip to content

Qpmnguyen time agg vignette #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 9, 2022
Merged

Qpmnguyen time agg vignette #38

merged 7 commits into from
Feb 9, 2022

Conversation

ryantibs
Copy link
Member

@ryantibs ryantibs commented Feb 7, 2022

This is me working off of Quang's #37.

@ryantibs ryantibs marked this pull request as ready for review February 9, 2022 18:32
@ryantibs
Copy link
Member Author

ryantibs commented Feb 9, 2022

@qpmnguyen great job. I passed over and made edits here and there. Apart from condensing and rearranging text/code blocks, a brief summary:

  • Switched to Massachusetts and Vermont to demonstrate that if you use county name as the key, it'll fail, since they have overlapping county names
  • Induced missingness by censoring according to small values, to make the point that zero-filling can be important for downstream stuff like trailing averages

@ryantibs ryantibs merged commit e1e73cd into main Feb 9, 2022
@ryantibs ryantibs deleted the qpmnguyen-time-agg-vignette branch February 20, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants