Skip to content

Keep epi_df-ness in summarise + fix roxygen typos #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

brookslogan
Copy link
Contributor

No description provided.

@brookslogan
Copy link
Contributor Author

Closes #296. But this may not be the best way to do it. Maybe we'd get some of the intended behaviors of these reconstructing wrappers via implementing group_data.epi_df. But some might be unavoidable depending on grouped_df method implementations. There's also still issues with the metadata when binding rows which might be easier to resolve in some wrappers like the current approach (though none of them do that right now). Especially with dplyr 1.1.0 summarize that deprecates returning != 1 row per group, we may also have some re-keying hints that we might need to act upon.

@brookslogan brookslogan changed the base branch from main to dev April 7, 2023 09:13
@brookslogan
Copy link
Contributor Author

I think an alternative approach involving an "grouped_edf" class is going to be preferable.

@dshemetov dshemetov deleted the lcb/summarise-keep-epi-df-ness branch January 24, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants