Skip to content

Fix various documentation bugs noted in #217 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 27, 2023

Conversation

brookslogan
Copy link
Contributor

Still need to finish other tasks in #217 and add changelog entries.

Link to epidatr repo for now, as there's no doc site for it yet.
Fix vignette plots looking weird and discussion citing incorrect values at the
cost of requiring API access and higher run times.
Use backticks to denote code style (markdown in titles is enabled by
r-lib/pkgdown#2113). Use quotes for the affected title strings, as they all now
start with backticks, and backticks are not allowed at the start of unquoted(,
flow scalar) strings in YAML (https://www.yaml.info/learn/quote.html)
@brookslogan brookslogan marked this pull request as ready for review October 24, 2022 14:27
@brookslogan brookslogan requested a review from dajmcdon as a code owner October 24, 2022 14:27
@brookslogan
Copy link
Contributor Author

brookslogan commented Oct 24, 2022

Closes #217.

  • After merge: we'll want to check that the reference index renders the code style in the titles properly after merging, as GitHub Actions might be stuck with an older version.

@brookslogan
Copy link
Contributor Author

Think we're low on review power and these were pretty simple. Merging.

@brookslogan brookslogan merged commit a6e2eb6 into main Feb 27, 2023
@dshemetov dshemetov deleted the lcb/fix-various-doc-and-vignette-issues branch November 15, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants