-
Notifications
You must be signed in to change notification settings - Fork 8
Add changelog (NEWS.md), associated pkgdown styling #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On the version breakdown:
I'm not sure I understand the last parenthetical. If we're going to |
|
The main distinction is if epiprocess development is pushing directly to whatever branch/version epipredict is relying on.
For the still-still-pending PRs and issues with breaking changes that we're trying to get through soon in epiprocess, we should at least partially follow approach 2. But once they're all ready on some non-default branch, we'll be faced with a similar decision:
|
Looking at the mature Python package
So they choose to emphasize when a central piece is either added or updated. The "improvement" distinction is decided on each line when describing the change e.g.
We could do something similar for the core functionality like |
I'm not familiar enough with the details of this package to comment on past version attribution. So I'll only comment on My preference for having a I'm not entirely sure I understand the .9999 thing, but if it's just a placeholder until we agree on a release version, sounds good. And if I'm following the epipredict sync thread (which I'm not really sure that I am), I think that not having to pin epipredict to epiprocess versions every time is a benefit of having a separate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment above.
`pkgdown` seems to skip material preceding the first version number heading, as well as top-level headings that don't follow a certain format. Move the intro material to somewhere near the top where it won't be skipped; we'll need to move it again each time we release a version.
Thanks for the comments! I'm going ahead and merging this [so we can start adding changes to the changelog as part of other PRs]. Some improvements are deferred to later. |
Part of #177.
Decisions to be made:
main
continue to be a development branch? If so, we can just merge this into main. If not, we should PR the latest release into main so it gets the right version number[, or] just bump the version number in this PR [and release/tag it] (--> 0.5.1).Dan & Dmitry, your input would be very helpful here.
I've prepared some branches like 0.1.0_prep that we could then tag as 0.1.0 if we're happy with the retro version numbering. We should probably update the changelog inside of PRs moving forward.
(Note: we are trying to follow semver, but the .9999 thing wouldn't follow. It's to mark it as a dev version, not a release version. Seen in other R packages. The idea is to, at release time, look at the changes/changelog and decide what the semver release version number should be. Murky on what people actually recommend here.)