Fix epix_merge sync="truncate" err (with=F no j), add tests
#215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Add an internal warning + recovery if our DT preprocessing unexpectedly produces a DT with a different key (although in a way that won't catch if we accidentally mutated the original DT's key and matched it in the intermediate DT). If this is triggered, we will likely need to rethink/bugfix some other DT usage in other code which may have made similar assumptions about certain DT operations not dropping/modifying the key. - Edit the input to one set of epix_merge tests to make the truncate test more restrictive than it would have been otherwise, and edit a non-truncate test with an `expected` value that changes as a result.
|
dajmcdon
approved these changes
Aug 22, 2022
|
LGTM. Feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
produces a DT with a different key (although in a way that won't catch if we
accidentally mutated the original DT's key and matched it in the intermediate
DT). If this is triggered, we will likely need to rethink/bugfix some other DT
usage in other code which may have made similar assumptions about certain DT
operations not dropping/modifying the key.
restrictive than it would have been otherwise, and edit a non-truncate test with
an
expectedvalue that changes as a result.Closes #200.