Skip to content

Replaced n in epi_slide and epix_slide #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 68 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
1cf5aec
Updated code for separate PR to deal with coupling.
kenmawer Jul 14, 2022
d730876
Removed file that can cause conflicts due to differing branches.
kenmawer Jul 14, 2022
2d96c5a
Updated tests.
kenmawer Jul 14, 2022
4c45aa5
Fixed a typo.
kenmawer Jul 14, 2022
f06b7fe
Still needs work.
kenmawer Jul 14, 2022
8683249
Made updates as to be able to check after misunderstandings.
kenmawer Jul 15, 2022
3f42e60
Added spacing.
kenmawer Jul 15, 2022
08b22e5
Fixed a typo.
kenmawer Jul 15, 2022
d5a402c
Added a test that should be granted.
kenmawer Jul 15, 2022
dfc3566
Finally fixed epix_slide to work with the right value.
kenmawer Jul 15, 2022
62ce720
Updated data for testing
kenmawer Jul 15, 2022
5ee25e6
Still needs ref_time_values refactoring.
kenmawer Jul 15, 2022
ee9e9f6
Refactored `n` to `max_version_gap` and addressed a typo.
kenmawer Jul 18, 2022
ce44a28
Refactored code.
kenmawer Jul 18, 2022
7a32fbd
Merge branch 'main' of https://github.com/cmu-delphi/epiprocess into …
kenmawer Jul 18, 2022
2a0c97e
Changed outdated name.
kenmawer Jul 18, 2022
35f53d4
Removed defaults for `slide`.
kenmawer Jul 18, 2022
0258a03
Finally fixed an annoying bug on `advanced.Rmd`.
kenmawer Jul 18, 2022
c1369c2
Fixed errors; archive vignette still has errors.
kenmawer Jul 19, 2022
e2172a3
Pulled again to ensure matching.
kenmawer Jul 19, 2022
04302b6
Updated datasets as to run properly.
kenmawer Jul 19, 2022
feb0f47
0 errors or warnings!
kenmawer Jul 20, 2022
08a580d
Refactor of `ref_time_values` still needs fixing!
kenmawer Jul 20, 2022
666c4f7
Finally refactored incorrect time_values on epix_slide.
kenmawer Jul 20, 2022
3134a55
Changed ref_versions to refer to versions by default.
kenmawer Jul 21, 2022
bb39209
Some cleanup of slide; still incomplete.
kenmawer Jul 26, 2022
5984d8d
Still needs changes as before and after numbers are wrong.
kenmawer Jul 26, 2022
b68af0b
Changed bad formatting.
kenmawer Jul 26, 2022
b3229f2
Still needs refactoring.
kenmawer Jul 27, 2022
d18d98c
Redocumented with changes; still needs changes.
kenmawer Jul 27, 2022
121f9d2
Bad changes that break things.
kenmawer Jul 29, 2022
35811f1
Seems like merge is broken.
kenmawer Jul 29, 2022
06a6190
Updates relating to checking on main.
kenmawer Jul 29, 2022
37b3815
Merge branch 'main' of https://github.com/cmu-delphi/epiprocess into …
kenmawer Jul 29, 2022
f6e8795
Merge branch 'km-slide-n-replace' of https://github.com/dajmcdon/epip…
kenmawer Jul 29, 2022
ee10963
Seems broken beyond repair.
kenmawer Jul 29, 2022
05d84ca
Fixed tests.
kenmawer Jul 29, 2022
846b6ca
Fixed improper use of n.
kenmawer Jul 29, 2022
d55e6b8
This finally runs without errors.
kenmawer Jul 29, 2022
1158c8a
Note that epix_slide still hasn't been updated, and some epi_slide do…
kenmawer Jul 29, 2022
bbf5d6b
Need to ensure tests pass.
kenmawer Aug 5, 2022
b55d411
This shouldn't be here.
kenmawer Aug 5, 2022
b22ace3
Removed repetitive code and added more tests.
kenmawer Aug 6, 2022
feea2f4
Merge branch 'main' into km-slide-n-replace2.1
kenmawer Aug 8, 2022
1038e15
Ran document after updating to epidatr.
kenmawer Aug 9, 2022
6e2b207
Addressed first two comments.
kenmawer Aug 9, 2022
77b5bb9
Replaced `n` in details.
kenmawer Aug 9, 2022
db99a67
Updated some poorly typed documentation and an imporperly refactored …
kenmawer Aug 9, 2022
0456aff
Cleared unclear documentation and removed redundancy with slide's code.
kenmawer Aug 10, 2022
950ee8c
Added a test for blank `after`.
kenmawer Aug 10, 2022
d43cede
Refactored edf with grouped.
kenmawer Aug 10, 2022
039f33f
More fixes.
kenmawer Aug 10, 2022
93738aa
Updated `align`.
kenmawer Aug 10, 2022
8c601f8
Fixed inconsistency with test formatting.
kenmawer Aug 10, 2022
cfe2b55
Updated compactify on a vignette, added two tests for NA and put a te…
kenmawer Aug 10, 2022
6f91a55
Still need to do refactoring upon pulling.
kenmawer Aug 13, 2022
271ffe6
Still needs work.
kenmawer Aug 13, 2022
b0d751b
Still needs work, as slide necessitates that group_by be a string.
kenmawer Aug 15, 2022
9f46090
Pulled from v2.1.
kenmawer Aug 15, 2022
0498777
Still needs fixing.
kenmawer Aug 15, 2022
b9b9e6a
I somehow broke this.
kenmawer Aug 15, 2022
28a9c12
Vignettes are still failing.
kenmawer Aug 15, 2022
b407fdd
Check fails, but code chunk has `error = TRUE`.
kenmawer Aug 15, 2022
d14c0e8
Updated incorrect info.
kenmawer Aug 15, 2022
2b8690f
Added changes to awkward spacing and for the argument of before and a…
kenmawer Aug 17, 2022
3bd1368
I documented it.
kenmawer Aug 17, 2022
581648d
Refactored many things, but this still needs work.
kenmawer Aug 18, 2022
9980ec2
IDK what happened, but the refactoring went wrong.
kenmawer Aug 18, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/growth_rate.R
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
#' implicitly defined by the `x` variable; for example, if `x` is a vector of
#' `Date` objects, `h = 7`, and the reference point is January 7, then the
#' sliding window contains all data in between January 1 and 14 (matching the
#' behavior of `epi_slide()` with `n = 2 * h` and `align = "center"`).
#' behavior of `epi_slide()` with `before = 6` and `after = 7`).
#'
#' @section Additional Arguments:
#' For the global methods, "smooth_spline" and "trend_filter", additional
Expand Down
2 changes: 1 addition & 1 deletion man/growth_rate.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.