-
Notifications
You must be signed in to change notification settings - Fork 8
Updated testing for instatiation of an epi_archive #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hopefully just one more test to add (above). Please also address the warnings emitted by check() when running the tests: We should either capture/muffle these warnings, or pass/set things up so they are never generated (e.g., by passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Triggering GitHub to mark my review as complete, so that you can re-request review once again when you think these final couple of items are complete. (Trying to keep on top of reviews using https://github.com/pulls/review-requested)
Also, I realize that the as_epi_archive behavior here on a keyed DT when we don't pass other_keys seems a bit fishy. If they've keyed the thing appropriately with geo_type, time_type, {other keys}, version already, I believe this means that we drop all their {other keys} despite the data table key looking like a valid epi_archive DT key. Probably we want some type of warning here at least. Could be a separate issue. |
I agree with the most recent comment. However, I believe I have already seen this as an issue. |
Note that I may be mixing up a different issue with what should be addressed with the |
I didn't check to see if this was already filed as an Issue or not. Could you please confirm whether or not it is already filed? |
Also I realize I never "unresolved" the conversation with the "one more test to add (above)" so it was visible again --- please take a look. |
I didn't see the issue elsewhere about keys not being retained, so I filed it as #201. |
No description provided.