Skip to content

Updated testing for instatiation of an epi_archive #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 16, 2022

Conversation

kenmawer
Copy link
Contributor

No description provided.

@kenmawer kenmawer requested a review from brookslogan August 8, 2022 22:11
@brookslogan
Copy link
Contributor

Hopefully just one more test to add (above). Please also address the warnings emitted by check() when running the tests:
https://github.com/cmu-delphi/epiprocess/pull/159/checks#step:5:245

We should either capture/muffle these warnings, or pass/set things up so they are never generated (e.g., by passing compactify=TRUE if these are all just compactification warnings)

Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggering GitHub to mark my review as complete, so that you can re-request review once again when you think these final couple of items are complete. (Trying to keep on top of reviews using https://github.com/pulls/review-requested)

@brookslogan
Copy link
Contributor

brookslogan commented Aug 10, 2022

Also, I realize that the as_epi_archive behavior here on a keyed DT when we don't pass other_keys seems a bit fishy. If they've keyed the thing appropriately with geo_type, time_type, {other keys}, version already, I believe this means that we drop all their {other keys} despite the data table key looking like a valid epi_archive DT key. Probably we want some type of warning here at least. Could be a separate issue.

@kenmawer
Copy link
Contributor Author

I agree with the most recent comment. However, I believe I have already seen this as an issue.

@kenmawer
Copy link
Contributor Author

Note that I may be mixing up a different issue with what should be addressed with the key being dropped.

@kenmawer kenmawer requested a review from brookslogan August 10, 2022 22:26
@brookslogan
Copy link
Contributor

I didn't check to see if this was already filed as an Issue or not. Could you please confirm whether or not it is already filed?

@brookslogan
Copy link
Contributor

Also I realize I never "unresolved" the conversation with the "one more test to add (above)" so it was visible again --- please take a look.

@kenmawer
Copy link
Contributor Author

I didn't see the issue elsewhere about keys not being retained, so I filed it as #201.

@brookslogan brookslogan merged commit e106882 into cmu-delphi:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants