Skip to content

Update f documentation in epi_slide #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 16, 2022
Merged

Update f documentation in epi_slide #144

merged 7 commits into from
Jul 16, 2022

Conversation

rachlobay
Copy link
Collaborator

Addressed Issue #143 as per discussions with Logan. See the documentation for the f parameter in epi_slide and let me know if any re-wording would be helpful here.

@rachlobay rachlobay removed the request for review from dajmcdon July 13, 2022 19:45
@rachlobay rachlobay requested a review from dajmcdon July 14, 2022 20:24
@rachlobay
Copy link
Collaborator Author

@dajmcdon. This pull request has the two changes to [.epi_df that we discussed earlier today (1) removal of the two-ish lines of code in which an epi_df is converted to a tibble if column subsetting is performed and 2) Removal of the %>% group_by(geo_value) in the last two tests for epi_slide because as_tibble() in [.epi_df drops the grouping). Please review when you can (I think this should fix the R CMD Check errors for Maggie and Ken).

dajmcdon
dajmcdon approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@dajmcdon dajmcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue. Can you remove the .DS_Store file? Just add *.DS_Store to .gitignore

@rachlobay rachlobay merged commit cce84ad into main Jul 16, 2022
@rachlobay rachlobay linked an issue Jul 16, 2022 that may be closed by this pull request
Clean up epi_slide f parameter documentation #143
Closed
@dajmcdon dajmcdon deleted the doc_for_epi_slide_f_param branch July 16, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dajmcdon dajmcdon dajmcdon approved these changes

@brookslogan brookslogan Awaiting requested review from brookslogan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up epi_slide f parameter documentation
2 participants
@rachlobay @dajmcdon