Created an epi_df constructor
#104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajmcdon
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Looks good to me. @rachlobay Please merge if there's nothing outstanding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue 94, created a constructor for
epi_dfcallednew_epi_df(), which was added to the epi_df R script. By default, it builds an empty tibble with the correct metadata (based onas_epi_dffunction). Note that this was basically shifting some the code fromas_epi_df()to this new constructor function... I am not sure if that is ok as now the two functions have a lot of overlap, so let me know what you think. Also, there are some tests fornew_epi_df()in test-epi_df.R.Regarding
epi_archive,epi_archive$newis the public method that creates a newepi_archiveobject as $new is the constructor for R6 objects. So, I don't think that there is much to be done there, but maybe there is a modification you want me to make? In that case, let me know what that is on a separate issue.