Skip to content

Fix some attribution splicing #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue May 24, 2022 · 1 comment · Fixed by #86
Closed

Fix some attribution splicing #84

brookslogan opened this issue May 24, 2022 · 1 comment · Fixed by #86
Assignees
Labels
P0 high priority

Comments

@brookslogan
Copy link
Contributor

It looks like archive_cases_dv_subset, advanced.Rmd, archive.Rmd, and maybe other locations have an attribution for doctor-visits that got spliced with modification descriptions for jhu-csse. These should be de-spliced and the missing content added back.

@brookslogan
Copy link
Contributor Author

Spliced versions mix a link to doctor-visits data with a description of JHU-CSSE changes.

#' * \href{https://cmu-delphi.github.io/delphi-epidata/api/covidcast-signals/doctor-visits.html}{From the COVIDcast Epidata Doctor Visits API}: These signals are taken directly from the JHU CSSE \href{https://github.com/CSSEGISandData/COVID-19}{COVID-19 GitHub repository} without changes. The 7-day average signals are computed by Delphi by calculating moving averages of the preceding 7 days, so the signal for June 7 is the average of the underlying data for June 1 through 7, inclusive.
[From the COVIDcast Epidatab Doctor's Visit API](https://cmu-delphi.github.io/delphi-epidata/api/covidcast-signals/doctor-visits.html): 
 These signals are taken directly from the JHU CSSE [COVID-19 GitHub repository](https://github.com/CSSEGISandData/COVID-19) without changes. 

Plus, in context, it looks like some of the doctor-visits attribution has gone missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants