Add distn #88
Merged
Add distn #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge to pass tests.
Closed
Merge branch 'frosting' into add-distn # Conflicts: # NAMESPACE
ChloeYou
reviewed
Jul 12, 2022
| #' referring to the desired quantile. | ||
| #' @param symmetrize logical. If `TRUE` then interval will be symmetric. | ||
| #' @param name character. The name for the output column. | ||
| #' @param .flag a logical to determine if the layer is added. Passed on to |
There was a problem hiding this comment.
Is .flag still preserved or did we agree to remove it?
There was a problem hiding this comment.
It's there for now, just for consistency with the other layer_*() functions. But the plan is to change the name later. (Separate PR).
mgyliu
reviewed
Jul 13, 2022
Merge branch 'frosting' into add-distn # Conflicts: # NAMESPACE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #63 .
...args inlayer_predict()(see Allowlayer_predict()to pass along...#46 ) and prefer explicit quantile addition. This would use theslathermethod to process the output as needed (perhaps depending on the fitted model).