Skip to content

325 workflow adj #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 1, 2024
Merged

325 workflow adj #328

merged 5 commits into from
May 1, 2024

Conversation

dajmcdon
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@dajmcdon dajmcdon requested review from rachlobay and dshemetov April 30, 2024 22:53
rachlobay
rachlobay approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@rachlobay rachlobay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only thing is to handle the conflicting files before merging.

@dajmcdon
merge dev
f043918 
Merge branch 'dev' into 325-workflow-adj

# Conflicts:
#	_pkgdown.yml
@dajmcdon dajmcdon merged commit 5aa7828 into dev May 1, 2024
3 checks passed
@dajmcdon dajmcdon deleted the 325-workflow-adj branch May 1, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachlobay rachlobay rachlobay approved these changes

@dshemetov dshemetov Awaiting requested review from dshemetov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the add / remove / update functions to make sure they do not strip the epi_workflow class.
2 participants
@dajmcdon @rachlobay