Skip to content

refactor: update arx_forecaster predictor arg #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2024
Merged

refactor: update arx_forecaster predictor arg #312

merged 1 commit into from
Apr 7, 2024

Conversation

dshemetov
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Makes sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).

Change explanations for reviewer

Update the predictor default to the value of the outcome arg in arx_forecaster.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@dshemetov dshemetov requested a review from dajmcdon as a code owner April 4, 2024 23:07
@dshemetov dshemetov changed the title refactor: update arx_forecaster predictor arg #298 refactor: update arx_forecaster predictor arg Apr 4, 2024
Copy link
Contributor

@dajmcdon dajmcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should probably also exchange the ordering of the checks in validate_forecaster_inputs():

arg_is_chr(predictors)

@dshemetov
Copy link
Contributor Author

dshemetov commented Apr 5, 2024

Made the requested updates and force-pushed.


I'm getting the error locally

Error (test-target_date_bug.R:57:3): arx_classifier determines target_date where forecast_date exists
Error in `check_installs(object)`: This engine requires some package installs: 'xgboost'

which comes from the line

# test-target_date_bug.R, line 59
    trainer = parsnip::boost_tree(mode = "classification", trees = 5),

I guess xgboost is present on your machine and on CI, but I'm missing it, not sure how. Should we add it to Suggests or change the example to minimize dependencies? @dajmcdon

@dajmcdon
Copy link
Contributor

dajmcdon commented Apr 7, 2024

I suspect it's just a problem local to your machine. {xgboost} is in Suggests already, so it will be installed in CI.

@dshemetov dshemetov merged commit 114b0e7 into dev Apr 7, 2024
@dshemetov dshemetov deleted the ds/arxf branch April 7, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change predictors to default to outcome for arx_forecaster
2 participants