Skip to content

fix: #290 #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 4, 2024
Merged

fix: #290 #300

merged 17 commits into from
Apr 4, 2024

Conversation

dajmcdon
Copy link
Contributor

@dajmcdon dajmcdon commented Mar 28, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@dajmcdon dajmcdon requested a review from dshemetov March 28, 2024 17:34
@dajmcdon
Copy link
Contributor Author

dajmcdon commented Mar 28, 2024

@dshemetov I think this fixes your issue. This is technically a bug that may be on main. I'm not entirely sure if it (alone) would fix main however (I could not reproduce the NA's on the dev branch, only the incorrect target date).

Update:
In testing on main, the NA's remain in .pred_distn if: ahead = 7L and target_date = "2021-01-01". This is not the case on dev, despite the fact that there is a mismatch between forecast_date + ahead and target_date.

It's probably worth adding a check to the *_args_list() constructors to ensure that this isn't misspecified.

@dshemetov
Copy link
Contributor

dshemetov commented Apr 1, 2024

Hm, there's still an issue when using n_training < ahead in flatline_forecaster, gonna address in another PR.

@dshemetov dshemetov mentioned this pull request Apr 2, 2024
4 tasks
@dajmcdon dajmcdon merged commit 9d5cc5d into dev Apr 4, 2024
@dshemetov dshemetov deleted the djm/fix-290 branch April 4, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flatline_forecaster error when using target_date
2 participants