Skip to content

Set R-CMD-check to run on push & PR to v0.0.6 #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

brookslogan
Copy link
Contributor

Using the quick fix suggested by @dsweber2.

This only enables the checks on pushes & PRs to v0.0.6. If PRs to v0.0.6 are merged, this will NOT update the pkgdown site. @dajmcdon Would we be merging to v0.0.6 & want the pkgdown site to be updated?

@brookslogan brookslogan requested a review from dajmcdon as a code owner October 4, 2023 18:27
@dajmcdon
Copy link
Contributor

dajmcdon commented Oct 4, 2023

No pkgdown updates are needed for v0.0.6. The plan is to merge the (breaking) PRs into v0.0.6 (along with the CDC baseline). Then PR v0.0.6 to main.

@dajmcdon dajmcdon requested a review from dsweber2 October 4, 2023 19:06
Copy link
Contributor

@dajmcdon dajmcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsweber2 if this looks ok, then please approve / merge.

@dsweber2
Copy link
Contributor

dsweber2 commented Oct 4, 2023

yeah, that was roughly the suggestion. I'm a bit confused about the v0.0.6 branch, but that's a discussion for another time

@dsweber2 dsweber2 merged commit 69120e0 into main Oct 4, 2023
@dajmcdon dajmcdon deleted the run-checks-on-v0.0.6 branch June 18, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants