-
Notifications
You must be signed in to change notification settings - Fork 10
Added update.layer
and update_frosting
#221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…te_recipe, respectively)
Actually, hold up... I see that workflows |
Update: I’ve finished adding functions (+ tests) for add/update/remove a model and a recipe that work with an What I mean by the last sentence can be seen through the following example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- One structural issue which we can discuss.
- A few minor style issues.
- There's a stray file
R/add_model.Rd
to remove.
…edict into 73-update-layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a number of comments. The ideas are good but a few major changes:
- Add a
tidy()
method forfrosting
objects. - Allow the adjust methods to handle names as well as numbers.
- Create a short vignette that illustrates how these can be used. (including the
tidy()
methods for examining the recipe/frosting). - Run styler so that the code formatting matches the style on main.
Addresses #73. Added
update.layer()
andupdate_frosting()
along with tests for each.