Skip to content

Update to latest epidatr (fetch_tbl -> fetch) #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023

Conversation

brookslogan
Copy link
Contributor

Resolves breaking change from upstream cmu-delphi/epidatr#99. We "can't" >= the epidatr version dependency to try to get people better error messages because old versions hanging around are tagged "1.0.0" or maybe also "0.5.0", and we don't want to call the new version with this change something > "1.0.0".

@brookslogan brookslogan requested a review from dajmcdon as a code owner May 23, 2023 17:58
@dajmcdon
Copy link
Contributor

Just to check, this epidatr is now the version on main?

@brookslogan
Copy link
Contributor Author

Yes. I have another PR in epidatr pending that will bump the version to 0.6.0, though I'm not sure if it's useful for epipredict due to the old-1.0.0 problem.

@dajmcdon
Copy link
Contributor

Ah, I see. That's the epidatr@dev but epipredict uses epidatr@main currently. So we'll need to update the DESCRIPTION here as well.

@brookslogan
Copy link
Contributor Author

brookslogan commented May 23, 2023

Sorry, maybe not! Let me check more closely. [You already caught it. epidatr default branch is actually dev and it should have it]

@brookslogan
Copy link
Contributor Author

I don't think we need to update epipredict's DESCRIPTION. It doesn't specify @main so it will use the default branch, which is now @dev.

@dajmcdon dajmcdon merged commit c432003 into main May 23, 2023
@dajmcdon dajmcdon deleted the lcb/update-to-epidatr-fetch branch May 23, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants