Skip to content

population scaling function adjustments #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2022

Conversation

ChloeYou
Copy link
Contributor

Made adjustments based on the remaining comments in closed PR: #112

@ChloeYou ChloeYou requested a review from dajmcdon as a code owner September 16, 2022 02:39
@ChloeYou ChloeYou changed the title make adjustments based on Daniels comments population scaling function adjustments Sep 16, 2022
@dajmcdon
Copy link
Contributor

This looks good in principle, but it's failing the check. I'm not quite sure why. (I think in layer_population_scaling()). Fix that, and we're good.

Closes #137

@dajmcdon
Copy link
Contributor

Closes #135

@dajmcdon dajmcdon linked an issue Sep 17, 2022 that may be closed by this pull request
@dajmcdon dajmcdon merged commit 10e5df2 into frosting Sep 17, 2022
@dajmcdon dajmcdon deleted the 98-vignette-on-parsnip-and-recipes branch September 17, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel modification for population scaling
2 participants