Skip to content

Coming {workflows} update #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dajmcdon opened this issue Jun 28, 2022 · 0 comments · Fixed by #89
Closed

Coming {workflows} update #75

dajmcdon opened this issue Jun 28, 2022 · 0 comments · Fixed by #89
Assignees
@dajmcdon
Labels
bug Something isn't working

Comments

@dajmcdon
Copy link
Contributor

We use a LOT of functionality from the workflows package. A recent update to the dev branch on Github breaks the frosting postprocessor (0.2.6.9001).

If this goes to CRAN, we'll have to roll back. This issue is a reminder to post an issue to the workflows package.

It happens from in action.R from here to here. The specific bug is

order <- intersect(order, names(actions))

on line 56. This has the effect of enforcing no postprocessor (ever).
@dajmcdon dajmcdon added the bug Something isn't working label Jun 28, 2022
@dajmcdon dajmcdon self-assigned this Jun 28, 2022
dajmcdon added a commit that referenced this issue Jul 7, 2022
@dajmcdon
fix up failing checks, see issue #75
385e883
@dajmcdon dajmcdon mentioned this issue Jul 7, 2022
Merged
@dajmcdon dajmcdon linked a pull request Jul 7, 2022 that will close this issue
fix up failing checks, see issue #75 #89
Merged
dajmcdon added a commit that referenced this issue Jul 7, 2022
@dajmcdon
Merge pull request #89 from cmu-delphi/tests-hotfix
a7a83c5 
fix up failing checks, see issue #75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dajmcdon dajmcdon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix up failing checks, see issue #75 cmu-delphi/epipredict
1 participant
@dajmcdon