-
Notifications
You must be signed in to change notification settings - Fork 10
arx_fcast_epi_workflow
is not particularly user friendly
#215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
this is adjacent to #73, and I suspect is best thought of as a docs request in light of that |
Good point, David… I was looking into whether we should add something like this as it is a long rabbit hole to go down to get to the steps in a workflow using $… This isn’t merged yet (rather it is on the branch 73-update-layer), but do you think Here’s a quick example of what I was thinking
If yeah, this is ok with you, then I think it would be good to include this stuff somewhere in a doc example and possibly in a vignette as it would definitely be good for a user to know. |
That seems like a reasonable approach if you have an axe <- arx_fcast_epi_workflow(jhu, "death_rate", c("death_rate", "case_rate"))
axe$pre$actions$recipe$recipe$steps[[1]] <- update(axe$pre$actions$recipe$recipe$steps[[1]], lag = c(0,1:3,7))
axe$pre
which seems a bit unwieldy. |
Agreed. Hmmm.... I think to make the above work in as clean a format we can manage with what we have (on that branch), we could modify my code slightly by adding the |
What I mean by this is below... So, like before, we still have the base of the update recipe & workflow but now we've just also extracted the recipe before that. What do you think @dsweber2?
|
Seems good to me! Thanks for the extension |
There are apparently existing OKrs about this, but I wanted to put in an issue as well. I was attempting to modify just one step in an existing workflow (to allow for more
NA
filling in the frosting layer). Hypothetically there is a way to do this by intervening betweenarx_fcast_epi_workflow
andfit
, but the models are buried far too deep (ewf$pre$actions$recipe$recipe$steps
) to be usable by someone only somewhat familiar with the package.An idea would be to include a function like
get_step(workflow,n)
which could be used to get or set the nth step in the workflow.The text was updated successfully, but these errors were encountered: